Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance window rs #76

Merged
merged 10 commits into from
Jan 16, 2020
Merged

Maintenance window rs #76

merged 10 commits into from
Jan 16, 2020

Conversation

PacoDw
Copy link
Contributor

@PacoDw PacoDw commented Nov 25, 2019

Added:

  • maintenance_window resource
  • maintenance_window_test acceptance testing
  • maintenance_window website documentation.

You can run the acceptance test with:
make testacc

Terraform configuration:

Examples Usage

  resource "mongodbatlas_maintenance_window" "test" {
    project_id  = "<your-project-id>"
    day_of_week = 3
    hour_of_day = 4
  }

  resource "mongodbatlas_maintenance_window" "test" {
    project_id  = "<your-project-id>"
    start_asap  = true 
  }

@PacoDw PacoDw force-pushed the maintenance_window branch from 7f23213 to e657632 Compare November 25, 2019 19:37
@PacoDw PacoDw requested a review from SpencerBrown November 25, 2019 19:58
themantissa
themantissa reviewed Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things - thank you!

mongodbatlas/resource_mongodbatlas_maintenance_window.go Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_maintenance_window.go Outdated Show resolved Hide resolved
mongodbatlas/resource_mongodbatlas_maintenance_window.go Show resolved Hide resolved
website/docs/r/maintenance_window.html.markdown Outdated Show resolved Hide resolved
website/docs/r/maintenance_window.html.markdown Outdated Show resolved Hide resolved
website/docs/r/maintenance_window.html.markdown Outdated Show resolved Hide resolved
website/docs/r/maintenance_window.html.markdown Show resolved Hide resolved
website/docs/r/maintenance_window.html.markdown Show resolved Hide resolved
@PacoDw PacoDw requested a review from themantissa December 17, 2019 00:06
@PacoDw PacoDw force-pushed the maintenance_window branch from 38a8571 to c4b4a48 Compare December 26, 2019 16:27
@ghost ghost added size/XL and removed size/XXL labels Dec 26, 2019
themantissa
themantissa requested changes Dec 30, 2019
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small change in doc based on removing asap as a set-able value. Then it should be good!

website/docs/r/maintenance_window.html.markdown Outdated Show resolved Hide resolved
themantissa
themantissa approved these changes Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PacoDw PacoDw force-pushed the maintenance_window branch from b41e4fd to 3632ef5 Compare January 11, 2020 20:43
@ghost ghost added size/XXL and removed size/XL labels Jan 11, 2020
marinsalinas
marinsalinas approved these changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@marinsalinas marinsalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@PacoDw PacoDw merged commit ae2b73f into master Jan 16, 2020
@PacoDw PacoDw deleted the maintenance_window branch January 16, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themantissa themantissa themantissa approved these changes

@marinsalinas marinsalinas marinsalinas approved these changes

@shum shum Awaiting requested review from shum

@SpencerBrown SpencerBrown Awaiting requested review from SpencerBrown

Assignees
No one assigned
Labels
dependencies documentation size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PacoDw @marinsalinas @themantissa